⚡️ Golf cbrt by using a small table for an even better initial estimate and removing another iteration#1523
Merged
Merged
Conversation
…mate and removing another iteration
atarpara
pushed a commit
that referenced
this pull request
May 13, 2026
…mate and removing another iteration (#1523) * ⚡️ Golf `cbrt` by using a small table for an even better initial estimate and removing another iteration * Formatting
atarpara
added a commit
that referenced
this pull request
May 13, 2026
* rebase with origin/main * T * Added test * T * T * ⚡️ Golf `sqrt` and `cbrt` by getting a better initial estimate and removing an iteration (#1515) * ⚡️Golf `sqrt` and `cbrt` by getting a better initial estimate and removing an iteration * ⚡️Golf `cbrt` a little bit more by cutting corners during initialization * ⚡️ Golf `cbrt` by using a small table for an even better initial estimate and removing another iteration (#1523) * ⚡️ Golf `cbrt` by using a small table for an even better initial estimate and removing another iteration * Formatting * T --------- Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following on #1515, improve the implementation of
cbrtby using a small lookup table to seed the initial estimate based on the input octave. This allows us to remove 1 additional Newton-Raphson iteration, going down to 5.This PR was initially authored by AI (codex and claude) and then reviewed, validated, and cleaned up by a human (me). The formal proof of correctness was fully AI-authored.
Checklist
forge fmt?forge test?